Update documentation for RingLogger's ring buffer#37084
Merged
anusha-ragunathan merged 1 commit intomoby:masterfrom May 17, 2018
nwneisen:update-ring-buffer-documents
Merged
Update documentation for RingLogger's ring buffer#37084anusha-ragunathan merged 1 commit intomoby:masterfrom nwneisen:update-ring-buffer-documents
anusha-ragunathan merged 1 commit intomoby:masterfrom
nwneisen:update-ring-buffer-documents
Conversation
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Member
|
Thanks! |
Member
|
Member
|
Janky failing on #36501 |
Member
|
PowerPC also failing on a flaky test #32673 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fixes #36556
- What I did
Update RingLogger documentation to correctly describe the ring buffer's behavior.
- How I did it
Examined code to make sure documentation changes were accurate before modifying the comments.
- How to verify it
Read documentation before an after.
- Description for the changelog
Update documentation for RingLogger's ring buffer.
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Nick Neisen nwneisen@gmail.com