The Wayback Machine - https://web.archive.org/web/20260314084132/https://github.com/moby/moby/pull/37034
Skip to content

Add metrics for log failures/partials#37034

Merged
vdemeester merged 1 commit intomoby:masterfrom
cpuguy83:moar_metrics
May 14, 2018
Merged

Add metrics for log failures/partials#37034
vdemeester merged 1 commit intomoby:masterfrom
cpuguy83:moar_metrics

Conversation

@cpuguy83
Copy link
Member

No description provided.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤔

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #37034 into master will decrease coverage by 0.01%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master   #37034      +/-   ##
==========================================
- Coverage    35.1%   35.09%   -0.02%     
==========================================
  Files         615      616       +1     
  Lines       45793    45803      +10     
==========================================
- Hits        16077    16073       -4     
- Misses      27606    27622      +16     
+ Partials     2110     2108       -2

@vdemeester vdemeester merged commit ab0dccf into moby:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants