build(deps): bump github.com/docker/cli v29.4.0#13707
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
changed the title
thaJeztah
force-pushed
the
bump_cli
branch
2 times, most recently
from
c8dc735 to
c012d74
Compare
full diff: docker/cli@v29.3.1...v29.4.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the Docker CLI dependency to v29.4.0 and aligns e2e expectations with updated CLI error output.
Changes:
- Bump
github.com/docker/clifromv29.3.1tov29.4.0ingo.mod/go.sum. - Update compose run e2e tests to assert the new non-TTY stdin error message.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/e2e/compose_run_test.go | Adjusts expected stderr text for piped-stdin + TTY failure cases to match new CLI error wording. |
| go.mod | Bumps github.com/docker/cli requirement to v29.4.0+incompatible. |
| go.sum | Updates checksums for the bumped github.com/docker/cli version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Test that explicitly requesting TTY with piped input fails with proper error message | ||
| // This should trigger the "input device is not a TTY" error | ||
| cmd := c.NewCmd("sh", "-c", "echo 'test' | docker compose -f ./fixtures/run-test/piped-test.yaml run --rm --tty piped-test") | ||
| res := icmd.RunCmd(cmd) | ||
|
|
||
| res.Assert(t, icmd.Expected{ | ||
| ExitCode: 1, | ||
| Err: "the input device is not a TTY", | ||
| Err: "cannot attach stdin to a TTY-enabled container because stdin is not a terminal", |
There was a problem hiding this comment.
The inline comment says this should trigger the "input device is not a TTY" error, but the assertion below now expects a different stderr message. Update the comment to match the new message (or make it more general) to avoid misleading future readers.
| // Test that explicitly disabling --no-TTY (i.e., requesting TTY) with piped input fails | ||
| // This should also trigger the "input device is not a TTY" error | ||
| cmd := c.NewCmd("sh", "-c", "echo 'test' | docker compose -f ./fixtures/run-test/piped-test.yaml run --rm --no-TTY=false piped-test") | ||
| res := icmd.RunCmd(cmd) | ||
|
|
||
| res.Assert(t, icmd.Expected{ | ||
| ExitCode: 1, | ||
| Err: "the input device is not a TTY", | ||
| Err: "cannot attach stdin to a TTY-enabled container because stdin is not a terminal", |
There was a problem hiding this comment.
This comment mentions triggering the "input device is not a TTY" error, but the expected stderr assertion below was changed to a different message. Please update the comment to reflect the new error text (or avoid hard-coding the specific old message).
full diff: docker/cli@v29.3.1...v29.4.0
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did