Suppress the invalid media error in Stable#19969
Merged
Merged
Conversation
It's creating a lot of noise for folks, and it is not particularly _helpful_ since it does not specify a location or even name which resource failed to load or parse. On stable, let's just silently ignore them. Closes #19964
carlos-zamora
approved these changes
Mar 12, 2026
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
LGTM
Only note is that we probably shouldn't close #19964. Or if we do, perhaps file a follow-up to improve the warning to be more clear/helpful?
Member
Author
|
good call |
DHowett
added a commit
that referenced
this pull request
Mar 12, 2026
It's creating a lot of noise for folks, and it is not particularly _helpful_ since it does not specify a location or even name which resource failed to load or parse. On stable, let's just silently ignore them. Refs #19964 (cherry picked from commit 6d7fac9) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgnTk_w Service-Version: 1.24
DHowett
added a commit
that referenced
this pull request
Mar 12, 2026
It's creating a lot of noise for folks, and it is not particularly _helpful_ since it does not specify a location or even name which resource failed to load or parse. On stable, let's just silently ignore them. Refs #19964 (cherry picked from commit 6d7fac9) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgnTk_s Service-Version: 1.25
This was referenced Mar 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's creating a lot of noise for folks, and it is not particularly helpful since it does not specify a location or even name which resource failed to load or parse.
On stable, let's just silently ignore them.
Refs #19964