pkg/idtools: remove deprecated functions and types #50456
Merged
+0
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
impact/deprecation
kind/refactor
thaJeztah
force-pushed
the
idtools_rm_deprecated
branch
from
3be77e9 to
866a02b
Compare
Remove; - `MkdirAllAndChown` - `MkdirAndChown` - `MkdirAllAndChownNew` - `GetRootUIDGID` - `FromUserIdentityMapping` - `ToUserIdentityMapping` - `CurrentIdentity` - `IdentityMapping` - `Identity.Chown` - `IDMap` Also remove the temporary consts that were previously in use by BuildKit; - `SeTakeOwnershipPrivilege` - `ContainerAdministratorSidString` - `ContainerUserSidString` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
idtools_rm_deprecated
branch
from
866a02b to
a089c51
Compare
austinvazquez
approved these changes
Jul 21, 2025
dmcgowan
approved these changes
Jul 21, 2025
thaJeztah
commented
Jul 21, 2025
Comment on lines
3
to
4
| // Identity is either a UID and GID pair or a SID (but not both) | ||
| type Identity struct { |
There was a problem hiding this comment.
@dmcgowan This is the only thing remaining in this package; it could be moved to something something "volumes" in the daemon, but it's used in 2 packages / interfaces IIRC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove;
MkdirAllAndChownMkdirAndChownMkdirAllAndChownNewGetRootUIDGIDFromUserIdentityMappingToUserIdentityMappingCurrentIdentityIdentityMappingIdentity.ChownIDMapAlso remove the temporary consts that were previously in use by BuildKit;
SeTakeOwnershipPrivilegeContainerAdministratorSidStringContainerUserSidString- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)