refactor: thread context through publish sensitive data check#13653
Merged
glours merged 1 commit intodocker:mainfrom Mar 23, 2026
Merged
refactor: thread context through publish sensitive data check#13653glours merged 1 commit intodocker:mainfrom
glours merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes context cancellation propagation during the publish pre-checks by threading the caller’s ctx through the sensitive-data scan path, replacing a context.TODO() placeholder so that a cancelled publish can properly stop loader work.
Changes:
- Pass
ctxfrompublishintopreChecks. - Thread
ctxthroughcheckForSensitiveDataintocomposeFileAsByteReader. - Use the real
ctxinloader.LoadWithContextinstead ofcontext.TODO().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composeFileAsByteReaderusedcontext.TODO()as a placeholder, severingcancellation propagation. If the parent context is cancelled (e.g. Ctrl+C),
the loader call would continue running.
Threads the real
ctxthroughpreChecks->checkForSensitiveData->composeFileAsByteReader. No behavioral change.