Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Swarm: Add schema 3.11, and Allow additional properties in build
#4214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's a failure somewhere |
|
Yup! Sorry, should have left this as a draft, I wanted to look at the tests and add some but started looking at something else in the meantime and got distracted 😅 |
laurazard
force-pushed
the
compose-schema-x-props
branch
from
93bb623 to
73da2ab
Compare
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Since Swarm does not use the `build` section, there's no reason to validate properties here. This makes it so we don't have to keep updating the schema in the CLI to support properties added in the Compose Spec for build, and does not imply any new feature support since Swarm does not consider this section. Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
force-pushed
the
compose-schema-x-props
branch
from
73da2ab to
271b966
Compare
thaJeztah
changed the title
buildbuild
thaJeztah
changed the title
buildbuild
vvoland
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Since Swarm does not use the
buildsection, there's no reason to validate properties here.This makes it so we don't have to keep updating the schema in the CLI to support properties added in the Compose Spec for build, and does not imply any new feature support since Swarm does not consider this section.
- How I did it
Update the schema in the CLI to allow
additionalPropertiesinbuild.- How to verify it
Write a Compose file such as
and deploy it with
docker stack deploy -c <file> [name]- Description for the changelog
related:
buildfield indocker-compose.yamlschema #4113- A picture of a cute animal (not mandatory but encouraged)