builder: do not cancel buildkit status request#37597
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Aug 16, 2018
Merged
Conversation
tonistiigi
approved these changes
Aug 6, 2018
This fixes a bug when the build results in an error and instead of sending the logs of the container to the client, it signals a cancelation. The context should not be wired to the status request, as only the build requests need to be canceled. Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
fix-cancel-bug
branch
from
4460ec3 to
f1ef16c
Compare
Codecov Report
@@ Coverage Diff @@
## master #37597 +/- ##
=======================================
Coverage 35.62% 35.62%
=======================================
Files 611 611
Lines 44962 44962
=======================================
Hits 16017 16017
Misses 26736 26736
Partials 2209 2209 |
AkihiroSuda
approved these changes
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug when the build results in an error and instead of sending
the logs of the container to the client, it signals a cancelation.
The context should not be wired to the status request, as only the
build requests need to be canceled.
Signed-off-by: Tibor Vass tibor@docker.com