[18.09] Add libseccomp requirement for rpm packages#266
Merged
andrewhsu merged 1 commit intodocker:18.09from Nov 28, 2018
Merged
[18.09] Add libseccomp requirement for rpm packages#266andrewhsu merged 1 commit intodocker:18.09from
andrewhsu merged 1 commit intodocker:18.09from
Conversation
This requirement was originally added in 86f7649, but got removed in the migration to the new image-based packaging. Commit f2ceca9 added this requirement back for `.deb` packages, but did not include the same changes for RPMs. This patch adds back the requirement for RPM packages as well. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
justincormack
approved these changes
Nov 28, 2018
andrewhsu
approved these changes
Nov 28, 2018
Contributor
andrewhsu
left a comment
There was a problem hiding this comment.
LGTM
# yum --showduplicates list libseccomp # centos7
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
* base: mirror.web-ster.com
* extras: mirror.web-ster.com
* updates: mirror.web-ster.com
Available Packages
libseccomp.i686 2.3.1-3.el7 base
libseccomp.x86_64 2.3.1-3.el7 base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This requirement was originally added in 86f7649 (#75), but got removed in the migration to the new image-based packaging.
Commit f2ceca9 (#172) added this requirement back for
.debpackages, but did not include the same changes for RPMs.This patch adds back the requirement for RPM packages as well.