Fixes LCOW after containerd 1.0 introduced regressions#35320
Merged
mlaventure merged 1 commit intomoby:masterfrom Oct 27, 2017
Merged
Fixes LCOW after containerd 1.0 introduced regressions#35320mlaventure merged 1 commit intomoby:masterfrom
mlaventure merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: John Howard <jhoward@microsoft.com>
Member
|
If there were regressions I guess LCOW is missing test coverage. This should probably include some unit tests. |
Member
Author
|
@dnephin This needs end to end CI on RS3 which is being worked on. |
Member
|
end-to-end tests are not a substitute for unit tests. |
Member
Author
|
@dnephin I'm not saying they are, but unit tests are going to be a way off yet while the feature still has so many pieces not complete. |
thaJeztah
added
the
area/lcow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
@mlaventure @johnstep PTAL (would be good to get this merged ASAP).
Fixes #35302
#34895 regressed LCOW functionality. Two small spot fixes in this PR. Verified locally.