Check allNamespace config value while loading configuration file#1087
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 28, 2018
Merged
Check allNamespace config value while loading configuration file#1087thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Contributor
Author
|
Maybe we need a json schema on the configuration file... WDYT @vdemeester @thaJeztah ? |
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
bbad4d0 to
fb34ffc
Compare
vdemeester
approved these changes
May 28, 2018
Collaborator
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🎋
For json-schema, meh, we might at some point but it would probably be overkill for now 😓
Member
|
Agreed that JSON-schema could be nice at some point (also related to #1058), but I think there's more enhancements to be made (multiple configurations you can switch between etc), so perhaps better to keep it for a future rewrite of this stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
