Move output of stack rm to stdout#491
Conversation
|
Why should it go to stdout? |
|
Because it's not an error? See the following similar operations who send message to stdout: |
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
======================================
Coverage 48.8% 48.8%
======================================
Files 199 199
Lines 16389 16389
======================================
Hits 7998 7998
Misses 7976 7976
Partials 415 415 |
|
Ok, makes sense to be consistent with the other remove commands. The e2e test needs to be fixed as well |
| "Removing network bar_network1\n", | ||
| } | ||
| assert.Equal(t, strings.Join(expectedList, "\n"), fakeCli.OutBuffer().String()) | ||
| assert.Contains(t, fakeCli.ErrBuffer().String(), "Nothing found in stack: foo\n") |
There was a problem hiding this comment.
hmm, actually this seems weird. Why is it outputing both "nothing found in stack" and that it's removing things?
Not sure how this is passing. Something seems wrong
There was a problem hiding this comment.
Oh, nevermind, I see it now. There are two stacks, one is empty, the other is not.
|
Can you squash on merge? |
Signed-off-by: French Ben <frenchben@docker.com> Update for the test to capture the proper removal Signed-off-by: French Ben <frenchben@docker.com> Satisfy lint length limit Signed-off-by: French Ben <frenchben@docker.com> Updated e2e test Signed-off-by: French Ben <frenchben@docker.com>
6 participants
- What I did
Updated the output of
docker stack rmto be sent to stdout.Fixes #490
- How I did it
s/Err/Out- How to verify it
With no errors, doing
docker stack rm nginx 1>stdout.log 2>stderr.logshould show all output instdout- Description for the changelog
docker stack rmnow sends info messages to Stdout- A picture of a cute animal (not mandatory but encouraged)
