The Wayback Machine - https://web.archive.org/web/20260314081941/https://github.com/docker/cli/pull/1008
Skip to content

Revert unencryted storage warning prompt#1008

Merged
thaJeztah merged 1 commit intodocker:masterfrom
n4ss:revert-unencrypted-prompt
Apr 18, 2018
Merged

Revert unencryted storage warning prompt#1008
thaJeztah merged 1 commit intodocker:masterfrom
n4ss:revert-unencrypted-prompt

Conversation

@n4ss
Copy link
Contributor

@n4ss n4ss commented Apr 16, 2018

Signed-off-by: Nassim 'Nass' Eddequiouaq eddequiouaq.nassim@gmail.com

What is this change?

Reverting due to the unencrypted storage warning prompt breaking the build for some of the users: #561 (comment)

Anything left to do?

Short term

  • Add a deprecation note in the docs for an additional prompt for terminal users of this feature that would be added in 3 releases

Long term

  • Add the removed prompt making sure that both stdin & stderr (where the warning is outputted) are terminals

/cc @vdemeester @thaJeztah @cpuguy83

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
@n4ss
Copy link
Contributor Author

n4ss commented Apr 16, 2018

not sure what failed in the following:

20:11:06 --- FAIL: TestRemove (10.77s)
20:11:06 	remove_test.go:25: assertion failed: 
20:11:06 		Command:  docker stack rm test-stack-remove
20:11:06 		ExitCode: 1
20:11:06 		Error:    exit status 1
20:11:06 		Stdout:   Removing service test-stack-remove_one
20:11:06 		Removing service test-stack-remove_two
20:11:06 		Removing network test-stack-remove_default
20:11:06 		
20:11:06 		Stderr:   Failed to remove network spm73ru1a93b93wwr5qo2v72u: Error response from daemon: rpc error: code = FailedPrecondition desc = network spm73ru1a93b93wwr5qo2v72u is in use by task 590z2ts1llf2b0yr0hpexzay8Failed to remove some resources from stack: test-stack-remove
20:11:06 		
20:11:06 		
20:11:06 		Failures:
20:11:06 		ExitCode was 1 expected 0
20:11:06 		Expected stderr to contain "[NOTHING]"
20:11:06 		Expected no error
20:11:06 	remove_test.go:40: timeout hit after 10s: docker stack rm test-stack-remove failed : exit status 1
20:11:06 FAIL
20:11:06 FAIL	github.com/docker/cli/e2e/stack	11.009s

Tests work on my machine somehow..

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 🐸

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants