Merged
Conversation
added 2 commits
September 6, 2017 10:55
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
yongtang
approved these changes
Sep 10, 2017
Member
yongtang
left a comment
yongtang
left a comment
There was a problem hiding this comment.
I think the PR makes sense. LGTM if Jenkins passes.
yongtang
added
status/4-merge
rebuild/windowsRS1
and removed
status/2-code-review
labels
Member
Author
|
Jenkins & GH are out-of-sync. RS1 completed successfully here: https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/16941/console OK to merge? (Although restarted in the hope it will re-sync successfully) |
Member
|
All test passes now. Thanks! 👍 |
thaJeztah
added
the
area/lcow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Fixes internal VSO bug 12969254. Makes the VHDX boot read-only to avoid file sharing violation running 2nd container. @beweedon, @jstarks @PatrickLang FYI.
@johnstep PTAL.