-
Notifications
You must be signed in to change notification settings - Fork 2k
Add log-driver and options to service inspect "pretty" format #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please sign your commits following these rules: $ git clone -b "1943-bug-fix" git@github.com:RahulZoldyck/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
054b69f to
50b8b12
Compare
Codecov Report
@@ Coverage Diff @@
## master #1950 +/- ##
=========================================
Coverage ? 56.74%
=========================================
Files ? 310
Lines ? 21808
Branches ? 0
=========================================
Hits ? 12375
Misses ? 8518
Partials ? 915 |
|
@GordonTheTurtle requesting review for the PR |
|
Whoops, this one dropped off my list. Tested this, and looks good: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
ping @silvin-lubecki PTAL |
cli/command/service/formatter.go
Outdated
| Target: {{$secret.File.Name}} | ||
| Source: {{$secret.SecretName}} | ||
| {{- end }}{{ end }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need/want those empty lines in the template? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, it's a bit redundant as we have the indentation already (at least inconsistent). Let me clone this one and update that
933caf1 to
85c707c
Compare
Signed-off-by: Rahul Zoldyck <rahulzoldyck@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
85c707c to
139af1f
Compare
|
rebased, squashed, and removed the newlines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you @RahulZoldyck for your contribution!! 👍 |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

What I did
Fixes issue #1943 docker inspect not having log information
How I did it
Added template for Log Driver information in serviceInspectPrettyTemplate
How to verify it
Description for the changelog
Added Log Driver information in the prettify template.