The Wayback Machine - https://web.archive.org/web/20251014201758/https://github.com/moby/moby/pull/48695
Skip to content

Conversation

thaJeztah
Copy link
Member

- What I did

Now dockerd-rootless-setuptool.sh install --force ignores errors from rootlesskit.

This might be useful when installing Rootless Docker into a container image with RUN instructions.

- How I did it
Check --force

- How to verify it
dockerd-rootless-setuptool.sh install --force

- Description for the changelog

dockerd-rootless-setuptool.sh: let --force ignore smoke test errors

- A picture of a cute animal (not mandatory but encouraged)
🐧

Now `dockerd-rootless-setuptool.sh install --force` ignores errors
from `rootlesskit`.

This might be useful when installing Rootless Docker into a container
image with `RUN` instructions.

Fix issue 48678

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit fafdcd1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. impact/changelog area/rootless Rootless Mode labels Oct 18, 2024
@thaJeztah thaJeztah added this to the 27.4.0 milestone Oct 18, 2024
@thaJeztah thaJeztah self-assigned this Oct 18, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@thaJeztah thaJeztah merged commit b81bbc3 into moby:27.x Oct 18, 2024
144 checks passed
@thaJeztah thaJeztah deleted the 27.x_backport_fix_48678 branch October 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/rootless Rootless Mode impact/changelog kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants