Use scope=swarm for service related network inspect and revendor docker/docker

[yongtang]

This fix updates docker/docker to 4310f7da7e6bcd8185bf05e032f9b7321cfa6ea2 and use scope=swarm for service related network inspect.

This fix use scope=swarm for service related network inspect. The purpose is that, in case multiple networks with the same name exist in different scopes, it is still possible to obtain the network for services.

This fix is related to #167, moby/moby#30897, moby/moby#33561, moby/moby#30242

[codecov-io]

Codecov Report

Merging #184 into master will decrease coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   45.34%   45.33%   -0.01%     
==========================================
  Files         171      171              
  Lines       11482    11480       -2     
==========================================
- Hits         5206     5204       -2     
  Misses       5979     5979              
  Partials      297      297

[vdemeester]

LGTM 🐯

[aaronlehmann]

Sorry for my ignorance about network scoping, but I see that the node-local networks PR (moby/moby#32981) says it added the scope=swarm option to network create. Will the change here work correctly with networks that were created before that PR, and networks that are not node-local?

The only comment I have on the code itself is that there are many places that specify Verbose: false, but these are not needed because Verbose will default to false.

[dnephin]

I believe network scopes have existed since swarm was integrated, we just started exposing them to new endpoints more recently. So every swarm network should already have scope=swarm even if it was created before that PR.

[dnephin]

+1 to @aaronlehmann comment about removing Verbose: false, since it's default.

How will this work with older daemons that don't accept that query param? I believe they will just ignore the unexpected param, which means the behaviour is not any different from using an older client. Does that sound right?

[yongtang]

Thanks all for the review. The PR has been updated and now the unnecessary Verbose: false has been removed.

For moby/moby#32981, it adds allows a node-local network to be promoted to the swarm scope. Once a previous node-local network is promoted to swarm scope, it will be possible to be used by service created. For that the scope=swarm option passed in this PR is consistent with moby/moby#32981

[dnephin]

LGTM

[aaronlehmann]

LGTM