The Wayback Machine - https://web.archive.org/web/20250722122321/https://github.com/moby/moby/pull/49264
Skip to content

pkg/jsonmessage: JSONMessage: remove deprecated ProgressMessage, ErrorMessage #49264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 13, 2025


depends on these fixes to be released in docker-py;


  • ErrorMessage was deprecated in 3043c26
  • ProgressMessage was deprecated in 597e0e6

- What I did

- How I did it

- How to verify it

- Description for the changelog

pkg/jsonmessage: JSONMessage: remove deprecated ProgressMessage, ErrorMessage

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added area/api status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Jan 13, 2025
@thaJeztah thaJeztah added this to the 28.0.0 milestone Jan 13, 2025
@thaJeztah thaJeztah self-assigned this Jan 13, 2025
@thaJeztah thaJeztah force-pushed the jsonmessage_remove_deprecated branch from d4db89a to 73b0797 Compare January 13, 2025 13:20
@thaJeztah
Copy link
Member Author

docker-py error could be legit, which means it's depending on the deprecated fields;

=================================== FAILURES ===================================
_____________________ ImageCollectionTest.test_load_error ______________________
tests/integration/models_images_test.py:96: in test_load_error
    with pytest.raises(docker.errors.ImageLoadError):
E   Failed: DID NOT RAISE <class 'docker.errors.ImageLoadError'>
------- generated xml file: /src/bundles/test-docker-py/junit-report.xml -------

…rMessage

- ErrorMessage was deprecated in 3043c26
- ProgressMessage was deprecated in 597e0e6

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the jsonmessage_remove_deprecated branch from 58048d0 to 69eb214 Compare July 17, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant