-
Notifications
You must be signed in to change notification settings - Fork 2k
system/info: failure to connect to docker socket should propagate error #5918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5918 +/- ##
==========================================
- Coverage 59.33% 59.27% -0.07%
==========================================
Files 358 358
Lines 29783 29837 +54
==========================================
+ Hits 17672 17685 +13
- Misses 11142 11180 +38
- Partials 969 972 +3 🚀 New features to boost your workflow:
|
dcb5350 to
3c82131
Compare
56e6f6a to
7bec8d4
Compare
b69b09a to
c899a20
Compare
…uld propagate error This patch propagates the error up the stack when running `docker info` and a connection error to the server occurs. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
c899a20 to
353230d
Compare
|
@thaJeztah PTAL :) |
|
Ah, sorry, I should've replied; I started reviewing, but ran into some other fun issues; will give this another look today 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🙈 thought this one was already merged 🙈

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Closes #5900
- What I did
Propagate the failure to connect to the docker socket error up the stack.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)