The Wayback Machine - https://web.archive.org/web/20260314082948/https://github.com/docker/cli/pull/772
Skip to content

Fix bash completion for "docker swarm"#772

Merged
vdemeester merged 1 commit intodocker:masterfrom
muicoder:patch-1
Jan 2, 2018
Merged

Fix bash completion for "docker swarm"#772
vdemeester merged 1 commit intodocker:masterfrom
muicoder:patch-1

Conversation

@muicoder
Copy link
Contributor

"docker swarm" auto-completion is invalid.

@codecov-io
Copy link

codecov-io commented Dec 30, 2017

Codecov Report

Merging #772 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   53.46%   53.46%   -0.01%     
==========================================
  Files         218      218              
  Lines       14642    14642              
==========================================
- Hits         7829     7828       -1     
- Misses       6327     6328       +1     
  Partials      486      486

@albers
Copy link
Collaborator

albers commented Dec 30, 2017

Can you please explain why you want to remove support for docker swarm completion?

@muicoder
Copy link
Contributor Author

muicoder commented Dec 31, 2017

When I set DOCKER_HIDE_LEGACY_COMMANDS=true, swarm is not available, “swarm” is placed in legacy_commands, it should not be in management_commands?

Usage:	docker COMMAND

A self-sufficient runtime for containers
......
Management Commands:
  checkpoint  Manage checkpoints
  config      Manage Docker configs
  container   Manage containers
  image       Manage images
  network     Manage networks
  node        Manage Swarm nodes
  plugin      Manage plugins
  secret      Manage Docker secrets
  service     Manage services
  stack       Manage Docker stacks
  swarm       Manage Swarm
  system      Manage Docker
  trust       Manage trust on Docker images (experimental)
  volume      Manage volumes

Commands:
  build       Build an image from a Dockerfile
  deploy      Deploy a new stack or update an existing stack
  login       Log in to a Docker registry
  logout      Log out from a Docker registry
  run         Run a command in a new container
  search      Search the Docker Hub for images
  version     Show the Docker version information

Run 'docker COMMAND --help' for more information on a command.

@albers
Copy link
Collaborator

albers commented Dec 31, 2017

Ah yes, you are right. docker swarm is a management command, not a legacy command.
Thanks very much for your fix.

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albers
Copy link
Collaborator

albers commented Dec 31, 2017

@muicoder Please sign your commit.

Signed-off-by: muicoder <muicoder@gmail.com>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏈

@vdemeester vdemeester merged commit b0efaae into docker:master Jan 2, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Jan 2, 2018
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Fix bash completion for "docker swarm"
Upstream-commit: b0efaae
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants