Add DOCKER_TLS environment variable for --tls option#863
Merged
thaJeztah merged 1 commit intodocker:masterfrom Feb 6, 2018
Merged
Add DOCKER_TLS environment variable for --tls option#863thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 52.93% 52.93%
=======================================
Files 245 245
Lines 15848 15848
=======================================
Hits 8389 8389
Misses 6905 6905
Partials 554 554 |
Member
|
design LGTM; can you also update https://github.com/docker/cli/blob/master/docs/reference/commandline/cli.md to mention the new environment variable, and squash your commits? ping @dnephin |
Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
WTFKr0
requested review from
mdlinville,
thaJeztah and
vdemeester
as code owners
vdemeester
approved these changes
Feb 6, 2018
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
Design and Code LGTM 🐝
|
@WTFKr0: Many thanks ! |
Contributor
|
@gbarr01 FYI when this goes into CE. |
mtatheonly
added a commit
to mtatheonly/source-to-image
that referenced
this pull request
Feb 10, 2020
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863)
mtatheonly
added a commit
to mtatheonly/source-to-image
that referenced
this pull request
Feb 12, 2020
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
mrhyperbit23z0d
added a commit
to mrhyperbit23z0d/YfCloudKitp
that referenced
this pull request
Jun 6, 2022
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
MachinesWhisper
added a commit
to MachinesWhisper/mdLinu
that referenced
this pull request
Jul 29, 2025
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
BloomBranch
added a commit
to BloomBranch/Automation
that referenced
this pull request
Aug 25, 2025
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
japanx001
added a commit
to japanx001/scoedges
that referenced
this pull request
Sep 19, 2025
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Add DOCKER_TLS environment variable for --tls option Upstream-commit: b5df4f6 Component: cli
dmarketcalls
added a commit
to dmarketcalls/runcobo
that referenced
this pull request
Nov 25, 2025
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
memaLuaeed
added a commit
to memaLuaeed/practical
that referenced
this pull request
Jan 1, 2026
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
statelyaistate
added a commit
to statelyaistate/viz
that referenced
this pull request
Jan 26, 2026
Add option to set TLS in default docker config from environment variable DOCKER_TLS, same as docker cli (docker/cli#863) Adds tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #760
- What I did
Add a new env var (DOCKER_TLS) for
--tlsoption- How I did it
The same way as the
--tlsverifyoption (DOCKER_TLS_VERIFY env var)- How to verify it
DOCKER_TLS=1 docker psreturn same response asdocker --tls ps- A picture of a cute animal (not mandatory but encouraged)
