windows: include labels when re-creating non-default nat networks #50447
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
|
LOL, I didn't even remember that it is my code from #43836 😅 |
akerouanton
approved these changes
Jul 21, 2025
akerouanton
added
platform/windows
status/2-code-review
area/networking
kind/bugfix
|
Thanks! This issue was introduced by 67c36d5, which was released in v24.0, so let me add cherry-pick labels. |
|
BuildKit failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this was missing.
- Human readable description for the release notes
- Ensure that Windows NAT networks are recreated with their original labels when the Engine restarts