The Wayback Machine - https://web.archive.org/web/20200427093150/https://github.com/Microsoft/vscode/pull/48290
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron v2.0.0 #48290

Merged
merged 21 commits into from Jun 8, 2018
Merged

Electron v2.0.0 #48290

merged 21 commits into from Jun 8, 2018

Conversation

@bpasero
Copy link
Member

bpasero commented Apr 20, 2018

Continuation from #47289

List of open electron-update related issues: query

@bpasero bpasero added this to the May 2018 milestone Apr 20, 2018
@NateLing

This comment has been minimized.

Copy link

NateLing commented May 4, 2018

merge this pr into vscode 1.24? the electron v2.0.0 release has published.

@bpasero

This comment has been minimized.

Copy link
Member Author

bpasero commented May 4, 2018

@NateLing no, Electron 2.0.0 is not stable for us to merge currently. You can see all the issues in this query. Feel free to jump in and help out 👍

@bpasero bpasero modified the milestones: May 2018, June 2018 May 8, 2018
@enihcam

This comment has been minimized.

Copy link

enihcam commented May 20, 2018

@bpasero How about 2.0.1? Have you tried to file those bugs to upstream?

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented May 20, 2018

@enihcam we're actively communicating with upstream to get these issues on their radar (when possible).

bpasero added 2 commits Jun 8, 2018
@bpasero bpasero merged commit e7d29e9 into master Jun 8, 2018
1 of 2 checks passed
1 of 2 checks passed
VSTS: VS Code in progress
Details
license/cla All CLA requirements met.
Details
@bpasero bpasero deleted the electron-2.0.x branch Jun 8, 2018
@kieferrm kieferrm mentioned this pull request Jun 11, 2018
43 of 52 tasks complete
@jens1o

This comment has been minimized.

Copy link
Contributor

jens1o commented Jun 13, 2018

@bpasero Are there any measurements(benchmark results) to compare how much faster it is now?

@bpasero

This comment has been minimized.

Copy link
Member Author

bpasero commented Jun 13, 2018

@jens1o I think @jrieken did a little bit of checks and found out it is a bit faster, but not sure how much (on startup).

@jens1o

This comment has been minimized.

Copy link
Contributor

jens1o commented Jun 13, 2018

okay, perhaps he can share them with us. I'd be very happy to have hard facts :)

@egamma egamma mentioned this pull request Jul 9, 2018
42 of 49 tasks complete
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.