The Wayback Machine - https://web.archive.org/web/20251014182257/https://github.com/moby/moby/pull/49746
Skip to content

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Apr 4, 2025

Use the same logic as push for determining whether a progress should be shown for a blob.

How to verify

docker pull ai/smollm2 should show any progress

Changelog

containerd image store: Show pull progress for non-layer image blobs

@vvoland vvoland added area/images Image Distribution kind/bugfix PR's that fix bugs containerd-integration Issues and PRs related to containerd integration area/ux labels Apr 4, 2025
@vvoland vvoland added this to the 28.0.5 milestone Apr 4, 2025
@vvoland vvoland self-assigned this Apr 4, 2025
@vvoland vvoland requested a review from rumpl April 4, 2025 13:45
Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@thaJeztah
Copy link
Member

@vvoland this one still draft?

@vvoland vvoland force-pushed the c8d-pull-progress-all branch from 0ab683e to 2ea5570 Compare April 7, 2025 09:00
@vvoland vvoland marked this pull request as ready for review April 7, 2025 09:00
@vvoland
Copy link
Contributor Author

vvoland commented Apr 7, 2025

Undrafted

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Use the same logic as push for determining whether a progress should be
shown for a blob.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the c8d-pull-progress-all branch from 2ea5570 to 7acef81 Compare April 7, 2025 11:31
@vvoland vvoland modified the milestones: 28.0.5, 28.1.0 Apr 7, 2025
@vvoland vvoland merged commit d9fd0c2 into moby:master Apr 7, 2025
160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/images Image Distribution area/ux containerd-integration Issues and PRs related to containerd integration impact/changelog kind/bugfix PR's that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants