Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Deprecate BridgeNfIptables and BridgeNfIp6tables fields #49114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The netfilter module is now loaded on-demand, and no longer during daemon startup, making these fields obsolete. These fields are now always `false` and will be removed in the next relase. This patch deprecates: - the `BridgeNfIptables` field in `api/types/system.Info` - the `BridgeNfIp6tables` field in `api/types/system.Info` - the `BridgeNFCallIPTablesDisabled` field in `pkg/sysinfo.SysInfo` - the `BridgeNFCallIP6TablesDisabled` field in `pkg/sysinfo.SysInfo` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
area/api
vvoland
approved these changes
Dec 17, 2024
thaJeztah
commented
Dec 17, 2024
Comment on lines
-270
to
-271
| info.BridgeNFCallIPTablesDisabled = !readProcBool("/proc/sys/net/bridge/bridge-nf-call-iptables") | ||
| info.BridgeNFCallIP6TablesDisabled = !readProcBool("/proc/sys/net/bridge/bridge-nf-call-ip6tables") |
There was a problem hiding this comment.
FWIW; this stops setting these fields, regardless of API version. I didn't update docs for older API versions, but given how we used this information thought it was OK to just stop setting it (worst case scenario, we add these lines back, and reset it in old API versions, but I highly doubt anyone outside of the daemon itself uses this information.
akerouanton
approved these changes
Dec 18, 2024
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The netfilter module is now loaded on-demand, and no longer during daemon startup, making these fields obsolete. These fields are now always
falseand will be removed in the next relase.This patch deprecates:
BridgeNfIptablesfield inapi/types/system.InfoBridgeNfIp6tablesfield inapi/types/system.InfoBridgeNFCallIPTablesDisabledfield inpkg/sysinfo.SysInfoBridgeNFCallIP6TablesDisabledfield inpkg/sysinfo.SysInfo- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)