2.5.0 regression: up with `--force-recreate` + `--no-deps` leads to "no such service" errors for dependent services

[nocive]

Description

Bringing a container up using a combination of the --force-recreate and --no-deps flags consistently leads to "no such service" errors for dependent services of the target service.
This works without problems with 2.4.1 but not in 2.5.0.

Steps to reproduce the issue:

1. docker compose up -d --force-recreate --no-deps SOME_SERVICE

Describe the results you received:
"no such service: some-dependent-service"

Describe the results you expected:
Container to be recreated and started without errors

Additional information you deem important (e.g. issue happens only occasionally):
Issue happens consistently with 2.5.0 but doesn't happen with 2.4.1.

Output of docker compose version:

Docker Compose version v2.4.1

[nicksieger]

I think this might be a difference in behavior from v1 to v2. v1 seems to happily ignore dependencies when you tell it --no-deps. v2 does not. Instead, it puts all services not mentioned on the command line into a slice of disabled services. Later when v2 prepares dependencies (always, regardless of whether --no-deps was supplied) is when the "no such service" error is produced.

#9368 added implicit deps for links since 2.4.1, are you dependencies declared as links? If not, I think the issue has been around longer than 2.4.1.

I am seeing this same issue with 2.5 with tilt-dev/tilt-example-docker-compose due to the implicit links dependency. Removing the dependency allows the service to be upped with --no-deps and v2.

[nicksieger]

FWIW this patch fixes the issue for me. If this behavior makes sense, I can open a PR with these changes.

1 file changed, 5 insertions(+), 1 deletion(-)
pkg/compose/create.go | 6 +++++-

modified   pkg/compose/create.go
@@ -183,7 +183,11 @@ func prepareServicesDependsOn(p *types.Project) error {
 		if service.DependsOn == nil {
 			service.DependsOn = make(types.DependsOnConfig)
 		}
-		deps, err := p.GetServices(dependencies...)
+
+		// Verify dependencies exist in the project, whether disabled or not
+		projAllServices := types.Project{}
+		projAllServices.Services = append(p.Services, p.DisabledServices...)
+		deps, err := projAllServices.GetServices(dependencies...)
 		if err != nil {
 			return err
 		}

[nocive]

thanks @nicksieger! 👍

[nocive]

this still happens with 2.6.1 🤷‍♂️

[nicksieger]

@nocive Oh no! Can you provide some more details? Here is the fixture for the test case I added to Compose's E2E test suite, for comparison.

[nocive]

@nicksieger I don't have an isolated reproduction scenario and I'm afraid I can't share many details about the setup where we're seeing this, but long story short:

• we have a huge docker compose project with 50+ containers
• in this setup we have all sorts of dependencies (declared using depends_on) using a mix of condition: service_started and condition: service_healthy conditions
• when we (re)build a service we want to purge the existing service (if any) and replace with the rebuilt one, and for that effect we would like to use docker compose up -d --force-recreate --no-deps $containers (currently we use a combination of docker compose rm -fsv $containers and docker compose up -d --no-recreate $containers)

At the moment, this workflow results in the aforementioned error and containers are left in "created" state and never started.

As an example:

 ⠿ Container my-service-1  Recreated                                                                                                                            0.5s
no such service: dependent-service-with-condition-healthy

$ docker compose ps my-service

NAME                           COMMAND                  SERVICE             STATUS              PORTS
my-service-1               "/entrypoint.sh"         my-service                created             

$ docker compose ps dependent-service-with-condition-healthy

NAME                 COMMAND                  SERVICE             STATUS              PORTS
dependent-service-with-condition-healthy-1   "docker-entrypoint.s…"   dependent-service-with-condition-healthy              running (healthy)   xxx

Please note that despite the error, the mentioned dependencies are in fact already running (and healthy).

Let me know if I can collect any other information you would find useful, otherwise I'll try to isolate this into a reproduction scenario when I find some time.