build: warning msg on deprecated flags

[crazy-max]

Relates to moby/moby#40379

Add warning message for deprecated flags via pflag annotations:

$ docker buildx build --load --squash --cgroup-parent /build .
WARN cgroup-parent is not implemented.
WARN squash flag was never taken out of experimental and is deprecated with BuildKit. You should squash inside build using the multi-stage feature for efficiency.
#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 2.94kB 0.1s done
#1 DONE 0.1s

• logrus formatter has been changed to avoid prefix like WARN[000].
• long description has been added to the root command.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

[tonistiigi]

Squash/Security-opt/isolation should be deprecated. Replacement for squash is to squash inside build (eg. in Dockerfile with additional stage). For Security-opt, RUN --security=insecure should be used. For --net=custom alternative is to set it on buildx create. I think this one could remain error.

For cgroup-parent I'm not sure. Maybe let's just implement it although it is a bad design. (edit: maybe implement and leave it as hidden?)

From quick overview, the rest can remain hidden as they were. No point to show these messages for flags that don't change build outcome and when we are not sure if they will fit in design or not.

For formatting, no capitalized messages. The logrus default seems fine to me.

[crazy-max]

Squash/Security-opt/isolation should be deprecated. Replacement for squash is to squash inside build (eg. in Dockerfile with additional stage). For Security-opt, RUN --security=insecure should be used. For --net=custom alternative is to set it on buildx create. I think this one could remain error.

Ok sgtm

For cgroup-parent I'm not sure. Maybe let's just implement it although it is a bad design. (edit: maybe implement and leave it as hidden?)

Yeah implement and keep it hidden lgtm.

From quick overview, the rest can remain hidden as they were. No point to show these messages for flags that don't change build outcome and when we are not sure if they will fit in design or not.

Done

For formatting, no capitalized messages.

Sure

The logrus default seems fine to me.

You mean with the default timestamp included so revert my changes?

[tonistiigi]

I guess plan was to implement this so set it in frontend-opt instead.

[tonistiigi]

Instead of --driver-opt network=host we could use the jaeger container IP directly. Or maybe there is a parameter for jaeger to listen 6831 on gateway IP. This can be done later as well.