Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
fix: buildx in k8s pod with kube client config in cluster #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Dec 4, 2020
| kcc = driver.KubeClientConfigInCluster{} | ||
| tryToUseKubeConfigInCluster = true | ||
| } else { | ||
| if _, err := kcc.ClientConfig(); err != nil { |
There was a problem hiding this comment.
Wouldn't hurt to logrus.Debug(err) here?
There was a problem hiding this comment.
i found kcc not be nil in cluster pod.
but not found other way to check local kube config exists.
not sure which logrus.Debug(err) you means? I haven't notice logrus.Debug in ClientConfig
There was a problem hiding this comment.
I thought printing the err with logrus.Debug(err) might be useful for debugging potential failures, but either is fine to me
AkihiroSuda
approved these changes
Dec 4, 2020
|
@morlay needs rebase (and maybe update) |
Signed-off-by: Wang <morlay.null@gmail.com>
|
@tonistiigi updated |
tonistiigi
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wang Jinglei morlay.null@gmail.com
use kube config in cluster not work with last PR #368
sorry for checking so late.