The Wayback Machine - https://web.archive.org/web/20251014210030/https://github.com/docker/cli/pull/757
Skip to content

Conversation

fp-pszczekutowicz
Copy link

- What I did
Fixed #756

- How I did it
Added return statement.

- How to verify it

  1. Create stack with service and config
  2. Deploy stack
  3. Update config file content
  4. Deploy stack
  5. Deploy should end with error

- Description for the changelog
Return errors from daemon on stack deploy configs create/update

Signed-off-by: Paweł Szczekutowicz <pszczekutowicz@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 18, 2017

Codecov Report

Merging #757 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants