The Wayback Machine - https://web.archive.org/web/20251014211921/https://github.com/docker/cli/pull/743
Skip to content

Fix external networks in stacks #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

Fix external networks in stacks #743

merged 1 commit into from
Dec 12, 2017

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Dec 11, 2017 •
edited
Loading

Fixes moby/moby#35755

Looks like I missed where the network name was used. I confirmed External.Name is no longer used anywhere after this patch.

@dnephin
Fix external networks
9da2602 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin requested a review from vdemeester as a code owner December 11, 2017 16:31
@dnephin dnephin added this to the 17.12.0 milestone Dec 11, 2017
vdemeester
vdemeester approved these changes Dec 11, 2017
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@codecov-io
Copy link

codecov-io commented Dec 11, 2017 •
edited
Loading

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

@dnephin dnephin requested a review from andrewhsu December 11, 2017 16:38
thaJeztah
thaJeztah approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit eb5e32e into docker:master Dec 12, 2017
@thaJeztah thaJeztah mentioned this pull request Dec 12, 2017
Merged
@dnephin dnephin deleted the compose-add-name-to-network branch March 12, 2018 15:03
@olljanat olljanat mentioned this pull request Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@andrewhsu andrewhsu Awaiting requested review from andrewhsu

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

17.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dnephin @codecov-io @vdemeester @thaJeztah @GordonTheTurtle