net7 cleanup and fix broken pinned/unmanaged flag detection

[mgravell]

the primary change here is to make AOT work, by removing any ref-emit, evil poking, or usage of MakeGenericType/MakeGenericMethod. This last required removing some T : unmanaged constraints (which is why we were using generics, because those scenarios couldn't be known statically), instead using evilness to keep things working - not least, a re-implementation of MemoryMarshal.Cast<TFrom, TTo> without the TFrom : struct, TTo : struct constraints (runtime checked, though) using MemoryMarshal.CreateSpan (note: on down-level TFMs, uses MakeGenericMethod to use the inbuilt Cast method, but that's fine: we don't need AOT on those platforms)

also:

• fix broken pinned/unmanaged flag detection
• cleanup and account for drift

[eerhardt]

Nice work! This is awesome. Thanks for making this library AOT-compatible.

[mgravell]

Re function pointers: partly perf, partly to avoid having to declare the type etc (can't use generics with spans), partly because they rock

…

On Wed, 3 May 2023, 16:01 Eric Erhardt, ***@***.***> wrote: ***@***.**** approved this pull request. Nice work! This is awesome. Thanks for making this library AOT-compatible. ------------------------------ In tests/AotTests/AotTests.csproj <#74 (comment)> : > @@ -0,0 +1,17 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <OutputType>Exe</OutputType> + <TargetFramework>net7.0</TargetFramework> + <Nullable>enable</Nullable> + <PublishAot>true</PublishAot> + ⬇️ Suggested change - + <TreatWarningsAsErrors>true</TreatWarningsAsErrors> ------------------------------ In src/Pipelines.Sockets.Unofficial/Arenas/PerTypeHelpers.cs <#74 (comment)> : > + Cast = (delegate*<Span<TFrom>, Span<TTo>>)concrete.MethodHandle.GetFunctionPointer(); + } + //Cast = (CastHelper)Delegate.CreateDelegate(typeof(CastHelper), null, concrete); (for my learning) Why function pointers here instead of a normal delegate? — Reply to this email directly, view it on GitHub <#74 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEHMDNCPKCCGDDSWQLXTDXEJXNJANCNFSM6AAAAAAXTE2UUA> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[mgravell]

v2.2.8 should be available

[lukebakken]

Thanks! I've been studying this and your other projects @mgravell to improve the RabbitMQ .NET client.