The Wayback Machine - https://web.archive.org/web/20250226132117/https://github.com/microsoft/vscode/pull/233175
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: synchronous script loading from web workers of extensions #233175

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix: synchronous script loading from web workers of extensions #233175

merged 2 commits into from
Dec 6, 2024

Conversation

pankajk07
Copy link
Contributor

@pankajk07 pankajk07 commented Nov 6, 2024 •
edited by deepak1556
Loading

Refs #233060

@pankajk07 pankajk07 mentioned this pull request Nov 6, 2024
Closed
deepak1556
deepak1556 requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I would like some time to investigate the underlying cause and the impact before pushing this as a fix.

You can always launch the application with the flag irrespective of this PR.

@mcpeakdb
Copy link

mcpeakdb commented Dec 3, 2024

hello, is there anything the community can do to help expedite this fix?

@deepak1556 deepak1556 enabled auto-merge (squash) December 6, 2024 13:46
@deepak1556 deepak1556 added this to the January 2025 milestone Dec 6, 2024
@deepak1556 deepak1556 changed the title fix: disabled PlzDedicatedWorker in Electron fix: synchronous script loading from web workers of extensions Dec 6, 2024
@deepak1556 deepak1556 merged commit ad42640 into microsoft:main Dec 6, 2024
7 checks passed
@pankajk07 pankajk07 deleted the pankajk07-patch-1 branch December 7, 2024 12:08
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@aiday-mar aiday-mar aiday-mar approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
4 participants
@pankajk07 @mcpeakdb @deepak1556 @aiday-mar