The Wayback Machine - https://web.archive.org/web/20251014201143/https://github.com/moby/moby/pull/45965
Skip to content

Add health start interval support to swarm mode #45965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2023
Merged

Add health start interval support to swarm mode #45965

merged 2 commits into from
Jul 14, 2023

Conversation

cpuguy83
Copy link
Member

Related: #45897

@cpuguy83 cpuguy83 mentioned this pull request Jul 13, 2023
Open
12 tasks
@cpuguy83 cpuguy83 added this to the 25.0.0 milestone Jul 13, 2023
@cpuguy83 cpuguy83 requested review from corhere and neersighted July 13, 2023 18:57
@cpuguy83 cpuguy83 linked an issue Jul 13, 2023 that may be closed by this pull request
Tracking issue for health start interval #45897
Open
12 tasks
@thaJeztah
Copy link
Member

quick blurb; need to check if the API is affected and swagger + version-history needs an update

@cpuguy83 cpuguy83 force-pushed the swarm_health_start_interval branch from fcd8d0f to bdd30a4 Compare July 13, 2023 19:11
@cpuguy83
Copy link
Member Author

@thaJeztah Yes API is affected but it was already updated in the original PR (b/c swarm is using the same struct in the swagger and in the actual API implementation).
I did need to update the swarm router to set the value to zero if the api version is older.

neersighted
neersighted approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the SwarmKit version to the commit message? e.g. make the first line vendor: github.com/moby/swarmkit/v2 v2.0.0-20230713153928-bc71908479e5?

Otherwise, LGTM

cpuguy83 added 2 commits July 14, 2023 16:46
@cpuguy83
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230713153928-bc71908479e5
16e6d8a 
This brings in changes needed to support health start intervals in
swarm.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83
Support for health start interval to swarm mode
f93cfb2 
Adds conversions for health start interval to/from grpc for swarmkit.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 force-pushed the swarm_health_start_interval branch from bdd30a4 to f93cfb2 Compare July 14, 2023 16:48
@cpuguy83
Copy link
Member Author

Updated the commit message.

thaJeztah
thaJeztah approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 37b908a into moby:master Jul 14, 2023
@cpuguy83 cpuguy83 deleted the swarm_health_start_interval branch July 14, 2023 22:55
@corhere corhere mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corhere corhere corhere approved these changes

@neersighted neersighted neersighted approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

area/api API area/swarm impact/changelog status/4-merge

Projects

None yet

Milestone

25.0.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for health start interval

4 participants

@cpuguy83 @thaJeztah @corhere @neersighted