The Wayback Machine - https://web.archive.org/web/20251014201112/https://github.com/moby/moby/pull/45484
Skip to content

Conversation

thaJeztah
Copy link
Member

relates to:

pkg/platform: remove deprecated OSType const

This const was deprecated in 5c78cbd (#45298), which
is part of the v24.0.0 release, so we can remove it from master.

pkg/ioutils: remove deprecated TempDir() alias

This function was deprecated in c63ea32 (#44515), which
is part of the v24.0.0 release, so we can remove it from master.

pkg/system: remove deprecated MemInfo, ReadMemInfo()

These were deprecated in 2d49080 (#44949), which
is part of the v24.0.0 release, so we can remove it from master.

pkg/system: remove deprecated DefaultPathEnv()

This was deprecated in 9f3e5ee (#44275), which
is part of the v24.0.0 release, so we can remove it from master.

pkg/system: remove deprecated IsProcessAlive, IsProcessZombie, KillProcess

These were deprecated in 9d5e754 (#44304), which
is part of the v24.0.0 release, so we can remove it from master.

api/types: remove deprecated AuthConfig

This was deprecated in 818ee96 (#43885), which
is part of the v24.0.0 release, so we can remove it from master.

api/types/container: remove deprecated ContainerChangeResponseItem

This was deprecated in dbb48e4 (#45353), which
is part of the v24.0.0 release, so we can remove it from master.

daemon: remove handling for deprecated "oom-score-adjust", and produce error

This option was deprecated in 5a922dc (#45315), which
is part of the v24.0.0 release, so we can remove it from master.

This patch;

  • adds a check to ValidatePlatformConfig, and produces a fatal error
    if oom-score-adjust is set
  • removes the deprecated libcontainerd/supervisor.WithOOMScore
  • removes the warning from docker info

With this patch:

dockerd --oom-score-adjust=-500 --validate
Flag --oom-score-adjust has been deprecated, and will be removed in the next release.
unable to configure the Docker daemon with file /etc/docker/daemon.json: merged configuration validation from file and command line flags failed: DEPRECATED: The "oom-score-adjust" config parameter and the dockerd "--oom-score-adjust" options have been removed.

And when using daemon.json:

dockerd --validate
unable to configure the Docker daemon with file /etc/docker/daemon.json: merged configuration validation from file and command line flags failed: DEPRECATED: The "oom-score-adjust" config parameter and the dockerd "--oom-score-adjust" options have been removed.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah added 8 commits May 6, 2023 16:36
This const was deprecated in 5c78cbd, which
is part of the v24.0.0 release, so we can remove it from master.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This function was deprecated in c63ea32, which
is part of the v24.0.0 release, so we can remove it from master.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These were deprecated in 2d49080, which
is part of the v24.0.0 release, so we can remove it from master.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was deprecated in 9f3e5ee, which
is part of the v24.0.0 release, so we can remove it from master.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…ocess

These were deprecated in 9d5e754, which
is part of the v24.0.0 release, so we can remove it from master.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was deprecated in 818ee96, which
is part of the v24.0.0 release, so we can remove it from master.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was deprecated in dbb48e4, which
is part of the v24.0.0 release, so we can remove it from master.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…e error

This option was deprecated in 5a922dc, which
is part of the v24.0.0 release, so we can remove it from master.

This patch;

- adds a check to ValidatePlatformConfig, and produces a fatal error
  if oom-score-adjust is set
- removes the deprecated libcontainerd/supervisor.WithOOMScore
- removes the warning from docker info

With this patch:

    dockerd --oom-score-adjust=-500 --validate
    Flag --oom-score-adjust has been deprecated, and will be removed in the next release.
    unable to configure the Docker daemon with file /etc/docker/daemon.json: merged configuration validation from file and command line flags failed: DEPRECATED: The "oom-score-adjust" config parameter and the dockerd "--oom-score-adjust" options have been removed.

And when using `daemon.json`:

    dockerd --validate
    unable to configure the Docker daemon with file /etc/docker/daemon.json: merged configuration validation from file and command line flags failed: DEPRECATED: The "oom-score-adjust" config parameter and the dockerd "--oom-score-adjust" options have been removed.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@rumpl @vvoland ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants