Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
fix mis-used skip condition #37179
Merged
fix mis-used skip condition #37179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
reviewed
May 31, 2018
integration/network/service_test.go
Outdated
There was a problem hiding this comment.
@AntaresS you can keep it on same line
There was a problem hiding this comment.
Also, no need to add version in the message string, off-by-ones can be confusing.
There was a problem hiding this comment.
@tiborvass Done. It's exceeding the ruler on my IDE, so thought would be better to split up into two lines.
Signed-off-by: Anda Xu <anda.xu@docker.com>
thaJeztah
added
status/4-merge
area/testing
rebuild/windowsRS1
and removed
status/2-code-review
labels
Codecov Report
@@ Coverage Diff @@
## master #37179 +/- ##
=========================================
Coverage ? 35.01%
=========================================
Files ? 615
Lines ? 45948
Branches ? 0
=========================================
Hits ? 16088
Misses ? 27748
Partials ? 2112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anda Xu anda.xu@docker.com
- What I did
skip.Iffunction from the previous PR - add api version checking for tests from new feature #37169- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)