The Wayback Machine - https://web.archive.org/web/20250210165413/https://github.com/microsoft/vscode/pull/65264
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #44237: Add column number in tasks #65264

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fixes #44237: Add column number in tasks #65264

merged 2 commits into from
Dec 10, 2024
+32 −0

Conversation

goodmind
Copy link
Contributor

@goodmind goodmind commented Dec 18, 2018 •
edited
Loading

@msftclas
Copy link

msftclas commented Dec 18, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues tasks Task system issues labels Dec 18, 2018
@goodmind
Copy link
Contributor Author

RIP

@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
@roblourens roblourens self-assigned this Dec 16, 2022
@roblourens roblourens assigned alexr00 and unassigned roblourens and weinand Dec 30, 2022
@roblourens
Copy link
Member

The PR is stale but as a feature this makes sense to me, why not provide the column if we provide the line?

@alexr00
Copy link
Member

alexr00 commented Jan 3, 2023

@goodmind this makes sense to me too. If you resolve the conflicts I'll try it out and see if we can merge it.

@alexr00 alexr00 added this to the January 2023 milestone Jan 3, 2023
@alexr00 alexr00 removed this from the January 2023 milestone Jan 24, 2023
@keithel
Copy link

keithel commented May 22, 2024 •
edited
Loading

Is there some sort of workaround for this? Some other way to get the current column of the cursor when invoking a task?

at the moment I don't have time to understand the details of how this fix is implemented enough to resolve the conflicts, but if I get some time, I'll take a stab at bringing the patch up-to-date.

@alexr00 alexr00 added this to the January 2025 milestone Dec 10, 2024
@alexr00 alexr00 mentioned this pull request Dec 10, 2024
Closed
@alexr00 alexr00 enabled auto-merge (squash) December 10, 2024 10:01
@alexr00 alexr00 merged commit 461a698 into microsoft:main Dec 10, 2024
7 checks passed
@keithel
Copy link

keithel commented Dec 13, 2024

I was looking at @goodmind 's commit and comparing it to what i was doing - similar, but i missed some things, and wow it looked quite different... Then I realized i was looking at a commit from 2018, and @alexr00 you merged master into his branch... Now it makes much more sense.

Thank you for doing this! It will be very helpful for people using the Axivion static analysis tool, and I'm sure many other uses.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lszomoru lszomoru lszomoru approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees

@alexr00 alexr00

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues tasks Task system issues variable-resolving
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
7 participants
@goodmind @msftclas @roblourens @alexr00 @keithel @lszomoru @weinand