The Wayback Machine - https://web.archive.org/web/20250209202323/https://github.com/microsoft/vscode-pull-request-github/pull/6525
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the python language user mention exception #6525

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove the python language user mention exception #6525

merged 1 commit into from
Dec 13, 2024

Conversation

NellyWhads
Copy link
Contributor

Motivation: #6469

Implementation:

  • Remove the default python language exception for user tags (@)

Tests:

  • Attempt to use python decorators without interjection from the extension

alexr00
alexr00 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! If users start complaining about this again I will add the default back in.

@alexr00 alexr00 enabled auto-merge (squash) December 13, 2024 13:28
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 13, 2024
@alexr00 alexr00 merged commit 188b1c2 into microsoft:main Dec 13, 2024
3 checks passed
@NellyWhads NellyWhads deleted the remove_python_user_exception branch December 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexr00 alexr00 alexr00 approved these changes

@aiday-mar aiday-mar aiday-mar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@NellyWhads @alexr00 @aiday-mar