The Wayback Machine - https://web.archive.org/web/20240814120612/https://github.com/docker/cli/pull/5325
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] update to go1.21.13 #5325

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Aug 7, 2024

go1.21.13 (released 2024-08-06) includes fixes to the go command, the covdata command, and the bytes package. See the Go 1.21.13 milestone on our issue tracker for details.

- Description for the changelog

Update Go runtime to 1.21.13

- https://github.com/golang/go/issues?q=milestone%3AGo1.21.13+label%3ACherryPickApproved
- full diff: golang/go@go1.21.12...go1.21.13

go1.21.13 (released 2024-08-06) includes fixes to the go command, the
covdata command, and the bytes package. See the [Go 1.21.13 milestone](https://github.com/golang/go/issues?q=milestone%3AGo1.21.13+label%3ACherryPickApproved)
on our issue tracker for details.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 434d8b7)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland
Copy link
Collaborator Author

vvoland commented Aug 7, 2024

Flaky test

 #20 59.66 Error: write /dev/pts/0: file already closed
#20 59.66 panic: Fail in goroutine after TestRunAttachTermination has completed
#20 59.66 
#20 59.66 goroutine 184 [running]:
#20 59.66 testing.(*common).Fail(0xc000092d00)
#20 59.66 	/usr/local/go/src/testing/testing.go:952 +0xd4
#20 59.66 testing.(*common).FailNow(0xc000092d00)
#20 59.66 	/usr/local/go/src/testing/testing.go:975 +0x26
#20 59.66 github.com/docker/cli/vendor/gotest.tools/v3/assert.ErrorIs({0x1033670, 0xc000092d00}, {0x102a960?, 0xc0004c4000}, {0x102aa40?, 0x16e0f30}, {0x0, 0x0, 0x0})
#20 59.66 	/go/src/github.com/docker/cli/vendor/gotest.tools/v3/assert/assert.go:311 +0x159
#20 59.66 github.com/docker/cli/cli/command/container.TestRunAttachTermination.func6()
#20 59.66 	/go/src/github.com/docker/cli/cli/command/container/run_test.go:85 +0x85
#20 59.66 created by github.com/docker/cli/cli/command/container.TestRunAttachTermination in goroutine 182
#20 59.66 	/go/src/github.com/docker/cli/cli/command/container/run_test.go:84 +0x486
#20 59.66 
#20 59.66 === FAIL: cli/command/container TestRunCommandWithContentTrustErrors/uninitialized-notary-server (unknown)

Opened a backport of a PR that fixed it: #5326

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (1cf3637) to head (53cb00a).
Report is 1 commits behind head on 27.x.

Additional details and impacted files
@@           Coverage Diff           @@
##             27.x    #5325   +/-   ##
=======================================
  Coverage   61.50%   61.50%           
=======================================
  Files         299      299           
  Lines       20867    20867           
=======================================
  Hits        12835    12835           
  Misses       7116     7116           
  Partials      916      916           

@vvoland vvoland requested a review from a team August 8, 2024 09:49
@vvoland vvoland merged commit 9593373 into docker:27.x Aug 8, 2024
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants