[27.0 backport] cli/config/credentials: ConvertToHostname: handle IP-addresses #5198
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 8b0a7b0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
impact/changelog
status/2-code-review
kind/bugfix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 27.0 #5198 +/- ##
==========================================
+ Coverage 61.39% 61.42% +0.02%
==========================================
Files 295 298 +3
Lines 20794 20799 +5
==========================================
+ Hits 12766 12775 +9
+ Misses 7112 7110 -2
+ Partials 916 914 -2 |
vvoland
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 8b0a7b0)
- What I did
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)