The Wayback Machine - https://web.archive.org/web/20240627123111/https://github.com/docker/cli/pull/5197
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.0 backport] re-introduced support for port numbers in docker registry URL #5197

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

thaJeztah
Copy link
Member

- What I did

- How to verify it

  • added new test cases and ran docker buildx bake test

- Description for the changelog

Fix a regression that caused port numbers to be ignored when parsing a Docker registry URL.

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Carston Schilds <Carston.Schilds@visier.com>
(cherry picked from commit 2380481)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 27.0.2 milestone Jun 26, 2024
@thaJeztah thaJeztah requested a review from vvoland June 26, 2024 12:14
@thaJeztah thaJeztah self-assigned this Jun 26, 2024
@thaJeztah thaJeztah changed the title re-introduced support for port numbers in docker registry URL [27.0 backport] re-introduced support for port numbers in docker registry URL Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.43%. Comparing base (fce24d5) to head (217971d).

Additional details and impacted files
@@           Coverage Diff           @@
##             27.0    #5197   +/-   ##
=======================================
  Coverage   61.42%   61.43%           
=======================================
  Files         298      298           
  Lines       20797    20799    +2     
=======================================
+ Hits        12775    12777    +2     
  Misses       7109     7109           
  Partials      913      913           

@thaJeztah thaJeztah merged commit 37533c2 into docker:27.0 Jun 26, 2024
107 of 113 checks passed
@thaJeztah thaJeztah deleted the 27.0_backport_fix_custom_ports branch June 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants