The Wayback Machine - https://web.archive.org/web/20250114211130/https://github.com/microsoft/vscode/pull/224102
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap end for flex-end in browser/hover.css #224102

Merged
merged 9 commits into from
Sep 11, 2024
Merged

Conversation

repraze
Copy link
Contributor

@repraze repraze commented Jul 27, 2024

Fixes incorect justify-content value set in #210472.

This resolves an autoprefixer warning while bundling with monaco-editor.

autoprefixer: end value has mixed support, consider using flex-end instead

Fixes justify-content value set in microsoft#210472 .

This resolves an autoprefixer warning while bundling with monaco-editor.

``` txt
autoprefixer: end value has mixed support, consider using flex-end instead
```
@Tyriar Tyriar assigned aiday-mar and unassigned Tyriar Aug 4, 2024
@aiday-mar aiday-mar enabled auto-merge (squash) August 20, 2024 07:39
@repraze
Copy link
Contributor Author

repraze commented Sep 11, 2024

Any issues merging this?

@aiday-mar
Copy link
Contributor

Hi thank you for the PR, this PR looks good, sorry. I think I previously approved it? Not sure what happened.

@aiday-mar
Copy link
Contributor

aiday-mar commented Sep 11, 2024

I will ask someone else to review it too. I think the PR did not receive enough approvals to be merged.

@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 11, 2024
@aiday-mar aiday-mar merged commit 17d912d into microsoft:main Sep 11, 2024
7 checks passed
@repraze
Copy link
Contributor Author

repraze commented Sep 11, 2024

Thanks! I'll be glad to see this warning gone.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants