[27.1 backport] attach: wait for exit code from ContainerWait

[laurazard]

backport #5297

- Description for the changelog

Fix `docker attach` exiting on `SIGINT` instead of forwarding the signal to the container and waiting for it to exit.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (fd3157b) to head (1cf3637).

Additional details and impacted files

@@           Coverage Diff           @@
##             27.x    #5302   +/-   ##
=======================================
  Coverage   61.50%   61.50%           
=======================================
  Files         299      299           
  Lines       20866    20867    +1     
=======================================
+ Hits        12834    12835    +1     
  Misses       7116     7116           
  Partials      916      916           

[vvoland]

Failures seem related to: #5229 (comment)

It added the "exit status " message, but wasn't backported to the 27.0 branch

[laurazard]

Ah, I guess it doesn't make since to backport #5229, so I'll adjust the expected output. WDYT @vvoland?

[vvoland]

I'm still unsure if we should have that message at all 😅 I think we still haven't decided if this is the expected behavior or not.
@thaJeztah WDYT?

[thaJeztah]

Oh! Good one; yes, I was considering if we need an explicit option on cli.StatusError to mark it as "silent" or something; effectively cli.StatusError should (probably?) be used as a wrapper for existing errors to add "status code" to them. Or at least, considering something like

err := foo()
if errdefs.IsNotFound(err) {
    // wrap the error with a atatus-code (and message?)
} 

For this branch I would update the tests to not check for the error-message if that works while we work out some of that.

[laurazard]

For this branch I would update the tests to not check for the error-message if that works while we work out some of that.

Updated.

[thaJeztah]

LGTM