The Wayback Machine - https://web.archive.org/web/20241116104707/https://github.com/dotnet/runtime/pull/105584
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HelperMethodFrame from GetMulticastInvoke #105584

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Jul 27, 2024

Move MethodTable acquisition from unmanaged to managed.
This allows for converting instance FCalls to static.

Move MethodTable acquisition from unmanaged to managed.
This allows for converting instance FCalls to static.
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review July 27, 2024 15:03
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
Copy link
Member

jkotas commented Jul 27, 2024

I see ~8% improvement in a delegate combine microbenchmark.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 3471de7 into dotnet:main Jul 27, 2024
90 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the hmf_delegates branch July 27, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants