The Wayback Machine - https://web.archive.org/web/20240912173537/https://github.com/dotnet/runtime/pull/100205
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove state machine allocation from HttpConnection.ReadAsync #100205

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

MihaZupan
Copy link
Member

This one was async solely to log a debug-level event.

Used by most of our H1 response content streams.

@MihaZupan MihaZupan added this to the 9.0.0 milestone Mar 24, 2024
@MihaZupan MihaZupan self-assigned this Mar 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On quick glance it doesn't look like an issue, but it'd be good to confirm there aren't any expected exceptions that might now escape synchronously into user code from a Task-returning method.

@MihaZupan
Copy link
Member Author

All our callers for this one are async at some point.

@stephentoub stephentoub merged commit 853bc58 into dotnet:main Mar 24, 2024
87 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants