The Wayback Machine - https://web.archive.org/web/20210104120651/https://github.com/microsoft/vscode-chrome-debug-core/issues/144
Skip to content

/ vscode-chrome-debug-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getPossibleBreakpoints to support column bps, when supported #144

Closed
roblourens opened this issue Jan 2, 2017 · 1 comment
Closed

Use getPossibleBreakpoints to support column bps, when supported #144

roblourens opened this issue Jan 2, 2017 · 1 comment
Labels
enhancement
Milestone
April 2017

Comments

@roblourens
Copy link
Member

@roblourens roblourens commented Jan 2, 2017 •
edited

https://chromedevtools.github.io/debugger-protocol-viewer/v8/Debugger/#method-getPossibleBreakpoints

I think when a BP is set at column x, need to call getPossibleBPs for line N, from column 0 to column x, and pick the last one.

If the runtime doesn't support that method, need to set the BP at column 0 (pre-sourcemapping)
@roblourens roblourens mentioned this issue Jan 2, 2017
Closed
@auchenberg
Copy link
Contributor

@auchenberg auchenberg commented Jan 3, 2017

Nicely spotted. This API must be used by Chrome's new inline-breakpoints feature.
@auchenberg auchenberg modified the milestone: Backlog Jan 9, 2017
@auchenberg auchenberg modified the milestone: Backlog Jan 26, 2017
@roblourens roblourens modified the milestones: April 2017, Backlog Apr 17, 2017
roblourens added a commit that referenced this issue Apr 18, 2017
@roblourens
For #144 - Handle multiple BPs at one location
45fd24e
roblourens added a commit that referenced this issue Apr 18, 2017
@roblourens
#144 - detect getPossBreakpoints API support ahead of time
Loading status checks…
012a56f
@kieferrm kieferrm mentioned this issue Apr 21, 2017
Closed
14 of 15 tasks complete
@roblourens roblourens mentioned this issue Apr 22, 2017
Closed
1 of 1 task complete
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
April 2017
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@auchenberg @roblourens
You can’t perform that action at this time.