Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upShow Preview button on mobile viewports #16496
+11
−11
Conversation
noisysocks
requested review from
talldan and
youknowriad
as
code owners
Jul 10, 2019
noisysocks
referenced this pull request
Jul 10, 2019
Closed
If a post is already published, you can't preview it from a mobile device #8184
noisysocks
added
the
Good First Review
label
Jul 10, 2019
youknowriad
added
the
Needs Design Feedback
label
Jul 10, 2019
jorgefilipecosta
approved these changes
Jul 10, 2019
|
Works well on my tests, and the code changes look good |
kjellr
approved these changes
Jul 10, 2019
|
Thanks, @noisysocks! I tested across a number of common mobile breakpoints, and this works well in all of them. |
This comment has been minimized.
This comment has been minimized.
|
This is great @noisysocks - let's ship! |
karmatosed
merged commit 1731607
into
master
Jul 10, 2019
1 of 9 checks passed
Filter merged
Filter merged
Details
Filter merged
Filter merged
Details
Filter merged
Filter merged
Details
Filter merged
Filter merged
Details
Filter merged
Filter merged
Details
Filter merged
Filter merged
Details
Filter merged
Filter merged
Details
Filter merged
Filter merged
Details
Travis CI - Pull Request
Build Passed
Details
github-actions
bot
added this to the Gutenberg 6.2 milestone
Jul 10, 2019
kjellr
deleted the
update/show-post-preview-button-on-mobile
branch
Jul 10, 2019
jg314
added a commit
to jg314/gutenberg
that referenced
this pull request
Jul 19, 2019
sbardian
added a commit
to sbardian/gutenberg
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
noisysocks commentedJul 10, 2019
Fixes #8184.
Displays the Preview button and renames Switch to Draft to Draft on mobile viewports. This allows mobile users to easily preview their published posts.
To test: