Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upHide the columns count control on empty columns block #16476
Conversation
youknowriad
added
[Type] Bug
[Block] Columns
Good First Review
labels
Jul 9, 2019
youknowriad
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
Soean and
talldan
as
code owners
Jul 9, 2019
youknowriad
self-assigned this
Jul 9, 2019
This comment has been minimized.
This comment has been minimized.
|
Fixes #16343 |
aduth
approved these changes
Jul 12, 2019
| @@ -170,9 +172,7 @@ export function ColumnsEdit( { | |||
| setForceUseTemplate( true ); | |||
| } } | |||
| __experimentalAllowTemplateOptionSkip | |||
| // setting the template to null when the inner blocks | |||
This comment has been minimized.
This comment has been minimized.
| return ( | ||
| <> | ||
| { template && ( | ||
| { ! showTemplateSelector && ( |
This comment has been minimized.
This comment has been minimized.
aduth
Jul 12, 2019
Member
Alternatively, I wonder what it is about choosing columns that causes the issue in the first place. If someone wanted to skip the layout selection and just start setting columns (assuming of an equal width), why prevent them?
This comment has been minimized.
This comment has been minimized.
youknowriad
Jul 12, 2019
Author
Contributor
yeah I'm not sure what. I decided to remove the selector not only because of the bug because based on the previous check here. I assumed that removing the inspector controls was an intentional behavior.
youknowriad
merged commit c3d80db
into
master
Jul 15, 2019
youknowriad
deleted the
fix/hide-columns-setup-state
branch
Jul 15, 2019
mcsf
added a commit
that referenced
this pull request
Jul 19, 2019
jg314
added a commit
to jg314/gutenberg
that referenced
this pull request
Jul 19, 2019
youknowriad
added this to the Gutenberg 6.2 milestone
Jul 26, 2019
sbardian
added a commit
to sbardian/gutenberg
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
youknowriad commentedJul 9, 2019
•
edited
Small regression introduced by #16129
closes #16343
When the columns block is in the "setup state", the columns count range control should be hidden.