The Wayback Machine - https://web.archive.org/web/20190826053049/https://github.com/WordPress/gutenberg/pull/16187
Skip to content

/gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable HTML block. #16187

Merged
merged 1 commit into from Jul 10, 2019
+1 −0

Conversation

@nicolad
Copy link
Member

commented Jun 15, 2019

Description

Fixes: #8245

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@nicolad nicolad added [Type] Enhancement [Block] HTML labels Jun 15, 2019

@nicolad nicolad requested review from ajitbohra, gziolo, jorgefilipecosta, notnownikki, Soean, talldan and youknowriad as code owners Jun 15, 2019

@nicolad

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 15, 2019

Had applied fix suggested by @mapk.
The usage of ResizableBox, as previously suggested, seems to be outside of the scope of the initial issue.
@nicolad

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 15, 2019

Here is testing:
Peek 2019-06-15 17-51
@mapk

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jun 25, 2019

Tested and it worked great! :shipit: :shipit:

@noisysocks noisysocks self-requested a review Jul 10, 2019

@noisysocks

noisysocks approved these changes Jul 10, 2019
View changes

@noisysocks noisysocks merged commit 9f1657d into master Jul 10, 2019
1 of 12 checks passed

1 of 12 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@noisysocks noisysocks deleted the update/html-block-textarea branch Jul 10, 2019

@noisysocks noisysocks referenced this pull request Jul 10, 2019
Closed

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

@nicolad @jg314
Applied max height to html block. (WordPress#16187)
e4fe90b

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

@nicolad @sbardian
Applied max height to html block. (WordPress#16187)
4537a0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks

@youknowriad youknowriad

@talldan talldan

@Soean Soean

@gziolo gziolo

@ajitbohra ajitbohra

@notnownikki notnownikki

@jorgefilipecosta jorgefilipecosta

Assignees
No one assigned
Labels
[Block] HTML [Type] Enhancement
Projects
None yet
Milestone
  Gutenberg 6.2
4 participants
@nicolad @mapk @noisysocks @youknowriad
You can’t perform that action at this time.